configurationProvider.ts: use integratedTerminal for cl.exe #11035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
approved these changes
May 31, 2023
caiohamamura
force-pushed
the
main
branch
2 times, most recently
from
e466cac to
c3faf98
Compare
|
Sorry @sean-mcmanus I just requested review from you again by mistake, I'm not changing anything, just rebasing to the most recent master to avoid the need for a commit merge when you actually merge this PR. |
sean-mcmanus
previously approved these changes
Jun 2, 2023
WardenGnaw
reviewed
Jun 2, 2023
|
So just this should be enough then? |
sean-mcmanus
approved these changes
Jun 9, 2023
WardenGnaw
approved these changes
Jun 9, 2023
michelleangela
approved these changes
Jun 15, 2023
|
@caiohamamura |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #11032
This patch will check if the compiler is
cl.exeand useintegratedTerminalinstead ofexternalTerminal.