Strip '\r' from the end of each line when parsing the vcpkg database #12416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
reviewed
Jun 26, 2024
bobbrow
reviewed
Jun 26, 2024
…soft/vscode-cpptools into browntarik/fixVcpkgParsing
sean-mcmanus
requested changes
Jun 26, 2024
bobbrow
reviewed
Jun 26, 2024
sean-mcmanus
approved these changes
Jun 26, 2024
browntarik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #12413
We were incorrectly parsing our vcpkg header database when deciding to present the "Learn how to install a library for this header with vcpkg" code action.
The issue was due to not stripping the "\r" line endings that appear exclusively on Windows machines.
This fix will now strip the "\r\n" line endings on windows properly and if will only strip "\n" for linux/mac machines.
It should now display the following behavior on windows (see below):
