Fix a potential race between didChange and didOpen
#13209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is for 1.24.0 or 1.23.5? i.e. should I cherry-pick it to the release branch? |
sean-mcmanus
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a potential (probably rare?) issue where it's possible that a call to
onDidChangeTextDocumentmight happen before a call toonDidOpenTextDocument, due to didOpen being delayed (processed by the protocol filter, after prior messages in queue). This could result the file's version inopenFileVersionsbecoming incorrect (though would be corrected by subsequent edits).onDidOpenTextDocumentandonDidChangeTextDocumentprimarily maintainopenFileVersions, and update UI state. This change callsonDidOpenTextDocumentusing a synchronous handler, instead of being processed by the protocol filter, ensuring no awaiting or prior queue work will delay it, similar to what we were already doing withonDidChangeTextDocument.Having
openFileVersionskept as closely in sync as possible with the editor ensures we properly discard results for operations that shouldn't be applied if the document has since changed.