Fix an issue with editorconfig tab_size #13216
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with
.editorconfig
tab_size
not being applied to VS Code's tab size when in "space" (soft tab) mode.I ran into this with the EDG codebase. (
host_envir.c/.h
are much easier to look at now).The new check seems simpler:
indent_style
is applied, only if present, to VS Code'sinsertSpaces
option.indent_size
is applied to VS Code'sindentSize
ANDtabSize
(as a fallback/default).tab
, VS Code'sindentSize
option is set to its own special value oftabSize
(telling VS Code to use the value oftabSize
instead).tab_width
is specified, it's applied to VS Code'stabSize
option.Based on information here: