Make commentContinuationPatterns, enhancedColorization and codeFolding window scope #5830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the following settings 'window' scope instead of 'resource' scope, to ensure proper behavior in multiroot workspaces.
commentContinuationPatterns- This usesvscode.languages.setLanguageConfiguration(), which is not resource (folder) specific.enhancedColorizationandcodeFolding- These involve registering providers. In order to support these on a per resource (per folder) basis, some additional work would be needed. However, it seems to make more sense for these settings to be window scope. We don't think user would want to vary these per folder.This change also updates
onDidChangeSettings()to only handle changes to these settings once instead of per folder.