Upgrade vscode-nls-dev module. Add translation hints for strings containing markdown #7620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-mcmanus
approved these changes
May 28, 2021
michelleangela
approved these changes
May 28, 2021
Colengms
changed the title
Merged
|
@Colengms Details are in the email I sent. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for translation hints (comments) have been added to the latest vscode-nls-dev.
This does not yet localize the Getting Started walkthough. We anticipate significant changes to the walkthrough in 1.5.0, so I don't want to make those strings localizable just yet. (Also, I need to finish #7538 )