Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmake language package in README #9442

Closed
wants to merge 2 commits into from
Closed

Update cmake language package in README #9442

wants to merge 2 commits into from

Conversation

hofbi
Copy link

@hofbi hofbi commented Jun 14, 2022

VS Code is recommending that the language support extension bundled with the cmake-tools package has been updated (see microsoft/vscode-cmake-tools#2597). This PR updates the reference in the README from the old to the recommended cmake language extentions.

ExtensionPack/README.md Outdated Show resolved Hide resolved
@hofbi hofbi requested a review from bobbrow June 14, 2022 17:59
@bobbrow
Copy link
Member

bobbrow commented Jun 14, 2022

@hofbi Thanks for doing this for us. The bad news is that I reviewed your PR prior to reviewing feedback from the CMake Tools community about this change, and we're actually going to revert the dependency back to the old extension and push an update imminently as a result.

@bobbrow bobbrow closed this Jun 14, 2022
@hofbi
Copy link
Author

hofbi commented Jun 14, 2022

Thanks for sharing.

I saw the old package got its last commit back in October 2019. Is there any expectation that this project will be further maintained?

@bobbrow
Copy link
Member

bobbrow commented Jun 14, 2022

I'm not sure what you mean. We updated it earlier this year.

image

@hofbi
Copy link
Author

hofbi commented Jun 14, 2022

What I mean is the CMake package that I was actually updating with my PR. This CMake package has its last commit from October 2019.

@bobbrow
Copy link
Member

bobbrow commented Jun 14, 2022

Ah, I see. At this point we don't expect that extension to update again. We still recommend the newer extension over the older one and added a note in the README.md to this effect, but compatibility issues that our customers encountered out of the box were what ultimately drove us to roll back the change. Just because we bundle this extension doesn't mean you have to use it. You can uninstall the old extension and install the newer one instead. We're keeping the bundle because it's important to have at least some level of support for the language.

@hofbi hofbi deleted the cmake-language-support branch June 14, 2022 21:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants