-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding subheaders to Extension settings #9985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggesting some settings moves
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having "IntelliSense" and "IntelliSense Configuration" seems a little confusing. Maybe rename "IntelliSense" to "IntelliSense Features" or combing them into "IntelliSense"?
Also, "IntelliSense Configuration" seems like it's just for the C_Cpp.default.* settings, in which case maybe calling it "IntelliSense Configuration Defaults" might be better or maybe moved to the IntelliSense section? It seems like an H3 group.
Extension/package.json
Outdated
"maximum": 65536, | ||
"scope": "machine" | ||
}, | ||
"C_Cpp.files.exclude": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This setting theoretically can apply to all features and not just IntelliSense, so it seems like it should be moved out, e.g. it'll get used by Code Analysis too (and that's in a different section), and we have a bug/TODO tracking making it work for formatting.
@Bernardin-MS FYI, my PR at #9979 made changes to the clang-tidy settings, so when you do the merge make sure those changes aren't lost (i.e. that's what's causing the current merge conflict). |
Are these settings System wide? Would something like IntelliSense PC Defaults work? |
How about "Configuration Defaults"? |
The scope can by anything, user to workspace folder. |
I worked with @Bernardin-MS on this and we reorganized a few settings/sections. This is the new order: |
I'm confused what goes in IntelliSense and what goes in Workspace Configuration. |
Issue: #8237
These are the subheaders
Outdated:
![image](https://user-images.githubusercontent.com/114429917/195379038-b547a46b-471a-4e6d-9345-4fb832bc095c.png)
Update:
![image](https://user-images.githubusercontent.com/114429917/197861708-55c9f455-1fdb-48e6-983c-a79d77b70941.png)