Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding subheaders to Extension settings #9985

Merged
merged 21 commits into from
Oct 28, 2022
Merged

Adding subheaders to Extension settings #9985

merged 21 commits into from
Oct 28, 2022

Conversation

Bernardin-MS
Copy link
Contributor

@Bernardin-MS Bernardin-MS commented Oct 11, 2022

Issue: #8237

These are the subheaders

Outdated:
image

Update:
image

Copy link
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting some settings moves

Extension/package.json Outdated Show resolved Hide resolved
Extension/package.json Outdated Show resolved Hide resolved
Extension/package.json Outdated Show resolved Hide resolved
Extension/package.json Outdated Show resolved Hide resolved
Extension/package.json Outdated Show resolved Hide resolved
Extension/package.json Outdated Show resolved Hide resolved
Extension/package.json Outdated Show resolved Hide resolved
Extension/package.json Outdated Show resolved Hide resolved
Extension/package.json Outdated Show resolved Hide resolved
Extension/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having "IntelliSense" and "IntelliSense Configuration" seems a little confusing. Maybe rename "IntelliSense" to "IntelliSense Features" or combing them into "IntelliSense"?

Also, "IntelliSense Configuration" seems like it's just for the C_Cpp.default.* settings, in which case maybe calling it "IntelliSense Configuration Defaults" might be better or maybe moved to the IntelliSense section? It seems like an H3 group.

"maximum": 65536,
"scope": "machine"
},
"C_Cpp.files.exclude": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting theoretically can apply to all features and not just IntelliSense, so it seems like it should be moved out, e.g. it'll get used by Code Analysis too (and that's in a different section), and we have a bug/TODO tracking making it work for formatting.

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Oct 13, 2022

@Bernardin-MS FYI, my PR at #9979 made changes to the clang-tidy settings, so when you do the merge make sure those changes aren't lost (i.e. that's what's causing the current merge conflict).

@Bernardin-MS
Copy link
Contributor Author

Having "IntelliSense" and "IntelliSense Configuration" seems a little confusing. Maybe rename "IntelliSense" to "IntelliSense Features" or combing them into "IntelliSense"?

Also, "IntelliSense Configuration" seems like it's just for the C_Cpp.default.* settings, in which case maybe calling it "IntelliSense Configuration Defaults" might be better or maybe moved to the IntelliSense section? It seems like an H3 group.

Are these settings System wide? Would something like IntelliSense PC Defaults work?

@bobbrow
Copy link
Member

bobbrow commented Oct 14, 2022

Having "IntelliSense" and "IntelliSense Configuration" seems a little confusing. Maybe rename "IntelliSense" to "IntelliSense Features" or combing them into "IntelliSense"?
Also, "IntelliSense Configuration" seems like it's just for the C_Cpp.default.* settings, in which case maybe calling it "IntelliSense Configuration Defaults" might be better or maybe moved to the IntelliSense section? It seems like an H3 group.

Are these settings System wide? Would something like IntelliSense PC Defaults work?

How about "Configuration Defaults"?

Extension/package.nls.json Outdated Show resolved Hide resolved
Extension/package.nls.json Outdated Show resolved Hide resolved
@sean-mcmanus
Copy link
Contributor

Are these settings System wide? Would something like IntelliSense PC Defaults work?

The scope can by anything, user to workspace folder.

@bobbrow
Copy link
Member

bobbrow commented Oct 24, 2022

I worked with @Bernardin-MS on this and we reorganized a few settings/sections. This is the new order:
image

Extension/src/common.ts Outdated Show resolved Hide resolved
Extension/src/common.ts Outdated Show resolved Hide resolved
@sean-mcmanus
Copy link
Contributor

I'm confused what goes in IntelliSense and what goes in Workspace Configuration.

@bobbrow bobbrow dismissed Colengms’s stale review October 26, 2022 17:52

Comments addressed

Extension/src/common.ts Outdated Show resolved Hide resolved
@bobbrow bobbrow merged commit 27abc63 into main Oct 28, 2022
@bobbrow bobbrow deleted the bdezius/8237 branch October 28, 2022 18:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants