Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an "origin" attribute to the debug protocol's "Source" type #5

Closed
weinand opened this issue Dec 23, 2015 · 1 comment
Closed

add an "origin" attribute to the debug protocol's "Source" type #5

weinand opened this issue Dec 23, 2015 · 1 comment
Labels
feature-request Request for new features or functionality

Comments

@weinand
Copy link
Contributor

weinand commented Dec 23, 2015

VSCode shows the description "internal module" in the editor's title for contents that doesn't come from a file but is returned from a debug adapter. For content that is inlined into a source map the description "internal module" is misleading.

I propose that we add an attribute "origin" to the debug protocol's "Source" type.

@isidorn what do you think? Is "origin" a good name or do you have a better suggestion?

@weinand weinand added the feature-request Request for new features or functionality label Dec 23, 2015
@isidorn
Copy link

isidorn commented Dec 23, 2015

I like this, we would fix the hack that I just give it the internal module name if it has a reference > 0.
👍 "origin" sounds good and precise to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants