network_mode: service:app breaks when rebuilding

[chrmarti]

We recreate only the DevContainer when rebuilding and the db container references the app container by id which then no longer exists. It doesn't immediately error out, but the db container can no longer be restarted and the db's port is not available in the new app container.

vscode-dev-containers/containers/javascript-node-mongo/.devcontainer/docker-compose.yml

Line 34 in 5940e56

network_mode: service:app

We can think about using docker-compose stop and then up to rebuild and would probably want to test that early in the milestone with insiders to understand the scope.

For now I suggest to turn the reference around and let app refer to db.

[Chuxel]

Got it - will make that change.

[Chuxel]

Fixed!