-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Node.js files to workspace breaks when package.json in subfolder #2057
Labels
Milestone
Comments
@ucheNkadiCode showed me that even if Dockerfile is edited with correct path to package.json, the image build still fails with the error mentioned in step 5. This seems wrong. |
I spoke to @philliphoff, and we think the best approach is this:
|
6 tasks
This is now fixed in Docker extension version 1.7.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I was following the Deploy images to ACI Tutorial and noticed that containerizing the app as-is was failing. I suspect it is because the package.json is found in a folder named
app
. Even though the docker-build and docker-run tasks don't reference this file, I am still blocked from hitting F5Repro Steps:
From Terminal
git clone https://github.com/Azure-Samples/aci-helloworld.git
into a folder of choicecode .
to open editorWithin VS Code
Ctrl + Shift + P
Add Dockerfile to workspace and select Node.jsmain
property inpackage.json
to "./app/index.js" but I'm unsure if this problem would have persisted in a fresh node project scenarioThe text was updated successfully, but these errors were encountered: