Significant refactoring of scaffolding #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 31, 2020
karolz-ms
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
This is a huge improvement, way to go, Brandon!!
I have looked at every file, but I won't pretend that I did a solid review of all of them, it was just too much, nor was I really that familiar with scaffolding code to begin with. That said, AFAIK it all looks very good to me. and even if there are some issues lurking, this change gives us much better basis to fix them and evolve the feature, that is why I say, let's ship it!
Dmarch28
pushed a commit
to Dmarch28/vscode-docker
that referenced
this pull request
Mar 4, 2021
* Prompt for requirements.txt replacement * Consistent behavior on prompting to replace * Allow custom scaffolding templates * Use a wizard for scaffolding
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a lot of scaffolding-related bugs and also allows for user-provided templates.
This PR is still early but I want to get it out there ASAP.