Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow usage without gnome-keyring installed #722

Closed
fedoraJ opened this issue Dec 30, 2018 · 3 comments · Fixed by #2220
Closed

Allow usage without gnome-keyring installed #722

fedoraJ opened this issue Dec 30, 2018 · 3 comments · Fixed by #2220
Labels
enhancement P2
Milestone
1.5.0

Comments

@fedoraJ
Copy link

fedoraJ commented Dec 30, 2018

Repro steps:
When I attempt to add a private registry that is hosted on my local (home lab) network I get the following error. The private registry has no authentication and I can see it is giving a 200 OK response to VSCode.

Action: vscode-docker.connectCustomRegistry
Error type: Error
Error Message: The name org.freedesktop.secrets was not provided by any .service files

Version: 0.4.0
OS: linux (Fedora 29 KDE spin)

This issue is related to #470 in that you can work around it by installing gnome-keyring. However, I have been purging everything gnome off of my system. Gnome-keyring was removed to force application to use KWallet instead. So, no I will not install it. Nor am I going to badger anyone about supporting KWallet. Rather I am asking that instead of throwing an error when it can't connect to libsecret, it prompts the user for a username and password when one is required (my private registry has none, it's not accessible outside my network.)
@StephenWeatherford
Copy link
Contributor

Currently on vacation.

@StephenWeatherford
Copy link
Contributor

We'll take a look, thanks.

@StephenWeatherford StephenWeatherford added this to the 0.6.0 milestone Jan 16, 2019
@PrashanthCorp PrashanthCorp modified the milestones: 0.6.0, 0.7.0 Feb 26, 2019
@PrashanthCorp PrashanthCorp added this to the 0.7.0 milestone Mar 6, 2019
@StephenWeatherford StephenWeatherford mentioned this issue Mar 8, 2019
Merged
@StephenWeatherford
Copy link
Contributor

Also see PR comments in #819 (comment)

@StephenWeatherford StephenWeatherford changed the title Adding private registry failes when gnome-keyring is not installed Allow usage without gnome-keyring installed May 21, 2019
@StephenWeatherford StephenWeatherford mentioned this issue May 21, 2019
Closed
@ejizba ejizba modified the milestones: 0.7.0, 0.8.0 Jun 18, 2019
@BigMorty BigMorty modified the milestones: 0.9.0, Future Sep 18, 2019
@bwateratmsft bwateratmsft mentioned this issue Oct 9, 2019
Closed
@bwateratmsft bwateratmsft mentioned this issue Mar 31, 2020
Closed
@bwateratmsft bwateratmsft mentioned this issue Apr 27, 2020
Closed
@bwateratmsft bwateratmsft mentioned this issue May 26, 2020
Closed
This was referenced Jul 27, 2020
Closed
Closed
@karolz-ms karolz-ms mentioned this issue Aug 6, 2020
Merged
karolz-ms added a commit that referenced this issue Aug 7, 2020
@karolz-ms
Allow authentication to registries without gnome-keyring (#2220)
15f125d 
Fixes #722
@bwateratmsft bwateratmsft modified the milestones: Future, 1.5.0 Aug 25, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 21, 2020
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this issue Mar 4, 2021
@karolz-ms @Dmarch28
Allow authentication to registries without gnome-keyring (microsoft#2220
ddb33f7 
)

Fixes microsoft#722
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement P2
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Allow authentication to registries without gnome-keyring
6 participants
@BigMorty @StephenWeatherford @ejizba @fedoraJ @PrashanthCorp @bwateratmsft