Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tasks to execute things instead of terminal windows #2173

Merged
merged 38 commits into from
Jul 20, 2020

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Jul 17, 2020

Fixes #251. This also requires doc updates for command customization.

@bwateratmsft bwateratmsft requested a review from karolz-ms July 17, 2020 13:12
@bwateratmsft bwateratmsft requested a review from a team as a code owner July 17, 2020 13:12
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, very clean change!

src/utils/executeAsTask.ts Outdated Show resolved Hide resolved
src/utils/spawnAsync.ts Show resolved Hide resolved
@bwateratmsft bwateratmsft merged commit 19a96b2 into master Jul 20, 2020
@bwateratmsft bwateratmsft deleted the bmw/terminals branch July 20, 2020 13:55
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

suggestion: option to reuse terminals
2 participants