Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker.context setting and support DOCKER_CONTEXT #2355

Merged
merged 7 commits into from
Sep 28, 2020
Merged

Add docker.context setting and support DOCKER_CONTEXT #2355

merged 7 commits into from
Sep 28, 2020

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Sep 28, 2020 •
edited
Loading

Fixes #2264

Tested:

  • Multiple ACI contexts open (using DOCKER_CONTEXT)
  • ACI and regular contexts open (using DOCKER_CONTEXT)
  • Multiple ACI contexts open (using docker.context)
  • ACI and regular contexts open (using docker.context)
  • Multiple contexts open (mixing DOCKER_CONTEXT and docker.context)
  • Verify DOCKER_HOST takes precedence over any context
  • Verify docker.host takes precedence over any context
  • Verify docker.context takes precedence over DOCKER_CONTEXT
  • Check behavior if docker.context / DOCKER_CONTEXT references an invalid context (compare behavior to CLI)
  • Check behavior if only one context exists
  • No changing context if DOCKER_HOST / docker.host / DOCKER_CONTEXT / docker.context are set

@bwateratmsft bwateratmsft requested a review from a team as a code owner September 28, 2020 20:28
karolz-ms
karolz-ms approved these changes Sep 28, 2020
View reviewed changes
src/docker/ContextManager.ts Show resolved Hide resolved
@bwateratmsft bwateratmsft merged commit c953343 into master Sep 28, 2020
@bwateratmsft bwateratmsft deleted the bmw/contextsetting branch September 28, 2020 21:30
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
@bwateratmsft @Dmarch28
Add docker.context setting and support DOCKER_CONTEXT (microsoft#2355)
cb6c661
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karolz-ms karolz-ms karolz-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a docker.context setting for setting DOCKER_CONTEXT similar to docker.host
2 participants
@bwateratmsft @karolz-ms