Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subset of services experiment #2657

Merged
merged 7 commits into from
Jan 27, 2021
Merged

Subset of services experiment #2657

merged 7 commits into from
Jan 27, 2021

Conversation

bwateratmsft
Copy link
Collaborator

@bwateratmsft bwateratmsft commented Jan 21, 2021

Fixes #2646. This adds a new option to launch a subset of services directly; basically it is equivalent to appending ${serviceList} to the end of your compose command. This is gated by an experiment.

image

image

@bwateratmsft bwateratmsft requested a review from a team as a code owner January 21, 2021 17:47
package.json Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to see that it is relatively easy to set up such experiment! ☺️

@bwateratmsft
Copy link
Collaborator Author

bwateratmsft commented Jan 21, 2021

@karolz-ms @BigMorty @ucheNkadiCode @philliphoff -- as an alternative, we could keep just one command and show the service checklist every time; we can do this as an experiment so we're not bothering everybody. We can measure success if people are actually using it; we capture the numerator (number of services selected) and denominator (total number of services). If selected < total, it stands to reason they did make use of the feature; otherwise not. If we saw, for example, that 95% were not using it, then combining commands is probably not the way to go. But if, say, 50% were using it--maybe one command is right.

Thoughts? In short, the options are:

  1. Separate "choose services" command, show the "choose services" command to the treatment group
    • Success: using this command
    • Success: the number of services selected being less than total number of services
    • Failure: people frequently start but cancel the "choose services" command
  2. One single command, show the subset picker to the treatment group
    • Success: the number of services selected is frequently less than the total number of services
    • Failure: very few people use the checklist; it's just a popup in the way

@BigMorty
Copy link
Member

Interesting idea @bwateratmsft. I could go either way, but I lean towards having the separate menu/command.

@bwateratmsft
Copy link
Collaborator Author

Interesting idea @bwateratmsft. I could go either way, but I lean towards having the separate menu/command.

That would be my inclination as well.

@bwateratmsft bwateratmsft merged commit 69cc10f into main Jan 27, 2021
@bwateratmsft bwateratmsft deleted the bmw/subset branch January 27, 2021 16:33
Dmarch28 pushed a commit to Dmarch28/vscode-docker that referenced this pull request Mar 4, 2021
@microsoft microsoft locked and limited conversation to collaborators Oct 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Right Click Option to "Select a subset of Compose services"
3 participants