Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all image RepoDigest values #2731

Merged
merged 1 commit into from
Feb 25, 2021
Merged

Check all image RepoDigest values #2731

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/tree/images/imageChecker/OutdatedImageChecker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,9 @@ export class OutdatedImageChecker {
// 2. Compare it with the current image's value
const imageInspectInfo = await ext.dockerClient.inspectImage(context, image.Id);

if (imageInspectInfo?.RepoDigests?.[0]?.toLowerCase()?.indexOf(latestImageDigest.toLowerCase()) < 0) {
// 3. If some local digest matches the most up-to-date digest, then what we have is up-to-date
// The logic is reversed so that if something goes wrong, we will err toward calling it up-to-date
if (imageInspectInfo?.RepoDigests?.every(digest => digest?.toLowerCase()?.indexOf(latestImageDigest.toLowerCase()) < 0)) {
return 'outdated';
}

Expand Down