Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide DevTools Console output when attached to a debug session #403

Closed
connor4312 opened this issue Jun 1, 2021 · 6 comments
Closed

Hide DevTools Console output when attached to a debug session #403

connor4312 opened this issue Jun 1, 2021 · 6 comments
Assignees
@bgoddar
Labels
bug Something isn't working

Comments

@connor4312
Copy link
Member

This seems to cause some confusion (microsoft/vscode#125071) and is redundant when launching from a js-debug session which already has output in the Debug Console
@bgoddar bgoddar added the bug Something isn't working label Jun 7, 2021
@bgoddar bgoddar self-assigned this Jun 9, 2021
@bgoddar
Copy link
Contributor

bgoddar commented Jun 9, 2021

Honestly, I don't think it makes much sense for us to include a limited/one-way console when instead we should just direct users to JS debug. I'll update with a Deprecation notice directing users to JS Debug, and we can remove entirely in a future update.

@bgoddar
Copy link
Contributor

bgoddar commented Jun 9, 2021

Hmmm. Actually, I guess the one case it might be useful is attaching to a target we are not using a debug session for. I'll discuss with the team if the best course of action is removing entirely or just disabling when attached to active target

This was referenced Jun 9, 2021
Closed
Merged
@codepo8
Copy link
Contributor

codepo8 commented Jun 22, 2021

This is an upcoming scenario now.

@bgoddar
Copy link
Contributor

bgoddar commented Jun 22, 2021

@codepo8 this is already checked in. Re-closing

@bgoddar bgoddar closed this as completed Jun 22, 2021
@bgoddar
Copy link
Contributor

bgoddar commented Jun 22, 2021

My mistake. Not checked in yet, but will be checked in today :)

@bgoddar bgoddar reopened this Jun 22, 2021
@codepo8 codepo8 closed this as completed Jun 28, 2021
@codepo8
Copy link
Contributor

codepo8 commented Jun 28, 2021

Added in the latest version of the extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bgoddar bgoddar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codepo8 @connor4312 @bgoddar