Remove console output in favor of JSDebug complete CDP Console #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le, and we should direct users there
|
I'm going to also stand up an alternate PR that just disables when we have attached through JSDebug, in case we want to keep this around for attaching to arbitrary sites. However, I prefer this solution |
Alternate solution is available here #412 |
|
Closing in favor of #412 for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes our console polyfills and replaces our current Devtools Console output with a single message that informs users to use JSDebug instead. Since JSDebug is a complete console experience already built into VSCode, it does not make sense for us to offer a duplicated and subpar one-way console output
Before:
After:
JSDebug Console:
Addresses #403