Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript configuration files detection #1968

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mustevenplay
Copy link

No description provided.

@dbaeumer
Copy link
Member

@mustevenplay thanks. It is my understand from the past that to be able to process TypeScript configuration files there needs to be used an experimental flag (see #1917). Are you planning to add support for this as well?

@dbaeumer dbaeumer added the info-needed Issue requires more information from poster label Jan 10, 2025
@davidenke
Copy link

@mustevenplay thanks. It is my understand from the past that to be able to process TypeScript configuration files there needs to be used an experimental flag (see #1917). Are you planning to add support for this as well?

I just encountered an error with eslint 9.18.0, that the flag is no longer needed:

Oops! Something went wrong! :(

ESLint: 9.18.0

Error: The flag 'unstable_ts_config' is inactive: This flag is no longer required to enable TypeScript configuration files.

I came from 9.10.0, back then it has been necessary.

@mustevenplay
Copy link
Author

Will any change to this PR be necessary then? I understand that a flag was required in previous versions in order to be able to use these Typescript configuration files, but is the intention to keep it backwards compatible? Or should we simply move on and assume the usage of the newer versions? @dbaeumer @davidenke

@davidenke
Copy link

AFAIK you still need jiti to be installed. Isn't it needed for this change as well?

@dbaeumer
Copy link
Member

@davidenke thanks for pointing this out. I wasn't aware of that.

I think that jiti needs to be specified in the package.json file and is nothing we need to handle in the extension. Otherwise validation wouldn't work in the terminal.

I think there is no need to make this backwards compatible. It would be fair IMO to ask users to use latest if they want TS config file support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants