Set xhr override before creating AppInsights client #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not supplied to the constructor the delegate AppInsightsCore class does not pick up the default channel (
BreezeChannelIdentifier = "AppInsightsChannelPlugin"
) plugin configuration and therefore doesn't use the supplied XHR override.This is subtle to notice when running in Node 18+ (VS Code 1.82+) since the AppInsights SDK mostly uses the
fetch
API which is available in Node and appears to work.This is similar to the pattern used for the 1DS client which presumably doesn't have the same issue and is where I got the idea to try it. Except the 1DS SDK separates the constructor from an
initialize
method:vscode-extension-telemetry/src/common/1dsClientFactory.ts
Line 50 in 3a87442