Code action test should wait for diagnostics #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jessienguyen2312 Thank you for the contribution. You have to do two more things:
|
|
@microsoft-github-policy-service agree |
karthiknadig
approved these changes
Oct 5, 2023
karthiknadig
changed the title
eleanorjboyd
reviewed
Oct 5, 2023
| @@ -14,6 +15,7 @@ | |||
| TEST_FILE_PATH = constants.TEST_DATA / "sample1" / "sample.py" | |||
| TEST_FILE_URI = utils.as_uri(str(TEST_FILE_PATH)) | |||
| LINTER = utils.get_server_info_defaults()["name"] | |||
| TIMEOUT = 10 # 10 seconds | |||
There was a problem hiding this comment.
is this in seconds or milliseconds?
There was a problem hiding this comment.
It is seconds. Python in most cases uses seconds and floating point for milliseconds
eleanorjboyd
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223 (comment)
Added time out procedure to def test_command_code_action(code, contents, command) based on the example on test_linting.py