add support for the experimental version of gocode running on go/packages #1932

stamblerre · 2018-09-17T23:44:39Z

This PR adds support for installing and switching between the regular version of certain Go tools and the versions that run on-top of go/packages (which works with Modules).

If the user is in a directory with a go.mod file, gocode-gomod will be executed, whereas if the user is in a normal $GOPATH workspace, the normal version will be executed. This allows users to test out their usual Go tools with Modules, while avoiding any bugs that may still be present, since these tools are still quite new.

For now, only gocode switches between gocode-gomod and gocode. godef-gomod can be downloaded, but it's not yet added in this change. Ideally, the version of the tool to run should be decided in a function like getBinPath, but I wanted to test one tool before using that approach.

ramya-rao-a · 2018-09-18T05:23:05Z

src/goInstallTools.ts

-				cp.execFile(goRuntimePath, ['get', '-u', '-v', allTools[tool]], { env: envForTools }, (err, stdout, stderr) => {
+				let args = ['get', '-u', '-v'];
+				if (tool.endsWith('-gomod')) {
+					args.push('-d');


Why are we choosing to not install and instead run a go build later?

Only "go build" has the -o flag that allows us to rename the binary to "gocode-gomod" instead of gocode, so I don't think there is a way to "go get" and rename the tool with one command.

ramya-rao-a · 2018-09-18T05:24:52Z

@stamblerre Thanks for the PR!

I have refactored the code in goSuggest.ts a bit and fixed linting errors that were breaking the build.
Also updated to include gocode-gomod in the list of tools to install only if Go version is 1.11. I am guessing we don't need this for Go 1.10.

Will test it out tomorrow and merge it.

stamblerre · 2018-09-18T18:49:09Z

It seems like the broken build is a result of an error in "fillStruct", which I don't think is related to this change.

stamblerre · 2018-09-21T14:31:11Z

@ramya-rao-a - just wanted to follow up, does this change seem ready to you?

ramya-rao-a · 2018-09-21T23:22:59Z

Yes, this looks good.

I wanted to make general changes on how to identify whether mod is supported and cache the results as well, but I can do that in the master branch.

I'll have a test build ready soon.

Thanks!

For more information see: microsoft/vscode-go#1932

fatih · 2018-09-21T23:31:58Z

I'm currently working on adding gocode-gomod as well, however, it only returns the candidates 20% of the time. I'm not sure what's going. I don't have much time this week (took a week off), but here is a WIP PR for vim-go: fatih/vim-go#1988

I'll check it again once I'm back in town.

stamblerre · 2018-09-21T23:42:44Z

Thanks for merging @ramya-rao-a. I'll probably have a similar PR soon for you for godef. Let me know if there are any problems with it.

ramya-rao-a · 2018-09-22T06:05:59Z

@stamblerre

I am seeing similar things as @fatih.

I just have a simple file with just 1 non std lib package dependency. It worked well for the past hour, but now I get "null" as the output from gocode-gomod all the time. It doesn't return results for std lib packages either at the moment

To test it out in VS Code:

Download https://github.com/Microsoft/vscode-go/blob/master/Go-gocode-mod.vsix
Run code --install-extension Go-latest.vsix
If the above fails with Error: end of central directory record signature not found, then clone this repo and use the Go-gocode-mod.vsix file from the cloned repo
Reload VS Code

stamblerre · 2018-09-23T23:06:56Z

I'm not sure if this will help fully, but I just pushed stamblerre/gocode@b960ec2, which should allow regular gocode and gocode-gomod run simultaneously. I'll try to keep using it though to see if I can find more problems.

ramya-rao-a · 2018-09-24T00:21:13Z

@stamblerre Anything we can do to help debug the issue where gocode returns the string "null"?

stamblerre · 2018-09-24T18:54:32Z

I haven't been able to reproduce that yet, but I am using gocode-gomod right now and trying to see if I can get it to happen. If you run "gocode-gomod close" and then "gocode-gomod -s -debug", and then try a completion and see what it prints out, that might give some useful information. Thanks!

ramya-rao-a · 2018-09-25T01:21:44Z

@stamblerre Below is the output from gocode-gomod -s -debug. I don't see anything that useful. It straight up says no candidates

2018/09/24 18:20:13 Got autocompletion request for '/Users/ramyar/Documents/go-modules/hello/hello.go'
2018/09/24 18:20:13 Cursor at: 92
2018/09/24 18:20:13 -------------------------------------------------------
package main

import (
        "rsc.io/quote"
        "fmt"
)

func main() {
        fmt.Println("hello")
        quote.#
}
2018/09/24 18:20:13 -------------------------------------------------------
2018/09/24 18:20:13 Elapsed duration: 91.238433ms
2018/09/24 18:20:13 Offset: 0
2018/09/24 18:20:13 Number of candidates found: 0
2018/09/24 18:20:13 Candidates are:
2018/09/24 18:20:13 =======================================================
2018/09/24 18:20:13 Got autocompletion request for '/Users/ramyar/Documents/go-modules/hello/hello.go'
2018/09/24 18:20:13 Cursor at: 114
2018/09/24 18:20:13 -------------------------------------------------------
package main
import "rsc.io/quote"

import (
        "rsc.io/quote"
        "fmt"
)

func main() {
        fmt.Println("hello")
        quote.#
}
2018/09/24 18:20:13 -------------------------------------------------------
2018/09/24 18:20:13 Elapsed duration: 90.077903ms
2018/09/24 18:20:13 Offset: 0
2018/09/24 18:20:13 Number of candidates found: 0
2018/09/24 18:20:13 Candidates are:
2018/09/24 18:20:13 =======================================================

ramya-rao-a · 2018-09-25T01:27:54Z

I know the repro steps for the failure now.

In the above example, I am using the quote package.

Say I used quote.Hello() and save the file. Subsequent quote. will give me completions.
Remove all quote related code and the import, save the file.
Add the quote package back to the import block. Don't save. Type quote. No completions.

On every file save, we run go build. This might be updating the module cache?

@fatih Do you see something similar?

stamblerre · 2018-09-25T01:59:09Z

Oh, so is the only problem you're seeing related to completing with unsaved imports?

ramya-rao-a · 2018-09-25T04:15:50Z

Yes, looks like that

stamblerre · 2018-09-25T16:45:04Z

Ok, I will try to investigate this error and see if I can resolve it. Though this doesn't seem like a huge deal to me--the pretty simple solution is to add the import back.

Dexus · 2018-10-18T17:49:55Z

src/goInstallTools.ts

 					if (stderr.indexOf('unexpected directory layout:') > -1) {
 						outputChannel.appendLine(`Installing ${tool} failed with error "unexpected directory layout". Retrying...`);
-						cp.execFile(goRuntimePath, ['get', '-u', '-v', allTools[tool]], { env: envForTools }, callback);
+						cp.execFile(goRuntimePath, args, { env: envForTools }, callback);
+					} else if (tool.endsWith('-gomod')) {


I'll never pass this in my tests. see #2024

@Dexus Did you try the latest from master?

You need to update either of gocode-gomod or godef-gomod via the Go: Install/Update Tools command to hit this else block

As in #2024 already pointed out I fix it myself with a copy. Would be nice if the current fix will be published asap. That works for me.

For more information see: microsoft/vscode-go#1932

stamblerre and others added 18 commits April 27, 2017 15:09

Add support for guru as a docs tool

4bb3035

Fixed linting errors

299a230

Use godoc as docs tool for extra info and signature

13dd59d

Merged goDeclaration

931e72d

Fix fallback to godoc in case of guru signature help

39637d1

Merge branch 'master' of https://github.com/Microsoft/vscode-go

df95609

Small change to make fallback to godoc work correctly

382baa0

Fall back to godoc for hover too

b47ccbd

Merge to upstream

555a491

Merge remote-tracking branch 'upstream/master'

2da91d2

Merge branch 'master' of https://github.com/Microsoft/vscode-go

a4ea6a8

doesn't work but mess around with adding gomod tools

63a25b8

latest deps

044ae3f

still doesn't fully work

2f8c307

working for gocode

20674e9

clean up installation a bit

ddc290b

refactor hasgomod

b1e1720

fix linting errors

f201c84

ramya-rao-a reviewed Sep 18, 2018

View reviewed changes

ramya-rao-a and others added 2 commits September 17, 2018 22:27

Include gocode-gomod only for Go 1.11

49ab915

remove logging

4719b28

ramya-rao-a and others added 4 commits September 19, 2018 23:36

Reduce the number of calls to go env gomod

7faa17e

Merge branch 'master' of https://github.com/Microsoft/vscode-go

67dba17

Merge branch 'master' of https://github.com/stamblerre/vscode-go

2ebfbed

revert package-json.lock

1764823

ramya-rao-a approved these changes Sep 21, 2018

View reviewed changes

ramya-rao-a merged commit fda88f0 into microsoft:master Sep 21, 2018

fatih added a commit to fatih/vim-go that referenced this pull request Sep 21, 2018

gocode: add support for experimantal gocode

33af63d

For more information see: microsoft/vscode-go#1932

fatih mentioned this pull request Sep 21, 2018

gocode: add support for experimental gocode fatih/vim-go#1988

Merged

stamblerre mentioned this pull request Sep 25, 2018

add support for go/packages version of godef (same as gocode) #1943

Closed

Dexus reviewed Oct 18, 2018

View reviewed changes

Dexus mentioned this pull request Oct 18, 2018

try to install gocode-gomod and godef-gomod but output panel stacking there #2024

Closed

bhcleek pushed a commit to fatih/vim-go that referenced this pull request Oct 21, 2018

gocode: add support for experimantal gocode

8b21b2d

For more information see: microsoft/vscode-go#1932

dzeban mentioned this pull request Jan 29, 2019

Use visualfc/gocode fatih/vim-go#2134

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add support for the experimental version of gocode running on go/packages #1932

add support for the experimental version of gocode running on go/packages #1932

stamblerre commented Sep 17, 2018

ramya-rao-a Sep 18, 2018

stamblerre Sep 18, 2018

ramya-rao-a commented Sep 18, 2018 •

edited

Loading

stamblerre commented Sep 18, 2018

stamblerre commented Sep 21, 2018

ramya-rao-a commented Sep 21, 2018

fatih commented Sep 21, 2018

stamblerre commented Sep 21, 2018

ramya-rao-a commented Sep 22, 2018 •

edited

Loading

stamblerre commented Sep 23, 2018

ramya-rao-a commented Sep 24, 2018

stamblerre commented Sep 24, 2018

ramya-rao-a commented Sep 25, 2018

ramya-rao-a commented Sep 25, 2018 •

edited

Loading

stamblerre commented Sep 25, 2018

ramya-rao-a commented Sep 25, 2018

stamblerre commented Sep 25, 2018

Dexus Oct 18, 2018

ramya-rao-a Oct 18, 2018

Dexus Oct 18, 2018

add support for the experimental version of gocode running on go/packages #1932

add support for the experimental version of gocode running on go/packages #1932

Conversation

stamblerre commented Sep 17, 2018

ramya-rao-a Sep 18, 2018

Choose a reason for hiding this comment

stamblerre Sep 18, 2018

Choose a reason for hiding this comment

ramya-rao-a commented Sep 18, 2018 • edited Loading

stamblerre commented Sep 18, 2018

stamblerre commented Sep 21, 2018

ramya-rao-a commented Sep 21, 2018

fatih commented Sep 21, 2018

stamblerre commented Sep 21, 2018

ramya-rao-a commented Sep 22, 2018 • edited Loading

stamblerre commented Sep 23, 2018

ramya-rao-a commented Sep 24, 2018

stamblerre commented Sep 24, 2018

ramya-rao-a commented Sep 25, 2018

ramya-rao-a commented Sep 25, 2018 • edited Loading

stamblerre commented Sep 25, 2018

ramya-rao-a commented Sep 25, 2018

stamblerre commented Sep 25, 2018

Dexus Oct 18, 2018

Choose a reason for hiding this comment

ramya-rao-a Oct 18, 2018

Choose a reason for hiding this comment

Dexus Oct 18, 2018

Choose a reason for hiding this comment

ramya-rao-a commented Sep 18, 2018 •

edited

Loading

ramya-rao-a commented Sep 22, 2018 •

edited

Loading

ramya-rao-a commented Sep 25, 2018 •

edited

Loading