feat: Upgrade requirement to 1.60.0 and apply folder-library icon
#997
Conversation
CsCherrYY
changed the title
folder-library icon1.60.0 and apply folder-library icon
| console.error('Error running tests:', err.message); | ||
| } finally { | ||
| await fs.remove(tmpDir); |
There was a problem hiding this comment.
there may be a bug between VSCode 1.60.0 (or maybe several versions older) and test-electron causing the user-dir is occupied after vscode instance exited in windows. Since we run the tests on pipeline, can we just remove the clean process here?
There was a problem hiding this comment.
what if I want to run tests on my dev machine which is Windows?
There was a problem hiding this comment.
A temporary folder will be created in os.tmpdir() to collect test logs. The size is about 80KB.
There was a problem hiding this comment.
Will it affect next run?
BTW, what's the purpose to remove this block? Is there any side-effect for the moment?
There was a problem hiding this comment.
Will it affect next run?
No. mkdtempSync() generates six random characters to be appended behind a required prefix to create a unique temporary directory. See
vscode-gradle/extension/src/test/runTests.ts
Line 183 in d74d483
BTW, what's the purpose to remove this block? Is there any side-effect for the moment?
Due to the bug in #997 (comment), the file is occupied, causing this remove() throws an error. You can see https://github.com/microsoft/vscode-gradle/runs/3582740912#step:15:382 for the reference.
There was a problem hiding this comment.
Got it. I'm fine with it. Better open an issue to test-electron repo.
| @@ -160,7 +160,7 @@ export class GradleTasksTreeDataProvider | |||
| vscode.TreeItemCollapsibleState.Collapsed, | |||
| element, | |||
| path.dirname(resourceUri.fsPath), | |||
| element.label || resourceUri.fsPath | |||
| typeof element.label === 'string' ? element.label : resourceUri.fsPath | |||
There was a problem hiding this comment.
The TreeItem.label could be string | TreeItemLabel in new index.d.ts.
CsCherrYY
added
eng
fix #994
Since
folder-libraryhas been shipped with VSCode 1.60.0, we can apply it and update our requirement.