Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel interrupt not working when interrupt mode is message (Julia on windows) #3927

Closed
DonJayamanne opened this issue Nov 16, 2020 · 2 comments
Closed

Kernel interrupt not working when interrupt mode is message (Julia on windows) #3927

DonJayamanne opened this issue Nov 16, 2020 · 2 comments
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel)

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Nov 16, 2020 •
edited
Loading

Our assumption is that kernel interrupts work with signals.
However kernels have the ability to get interrupted via messages.
This information is sent in the kernel info message.

Based on this we should use signals or messages.

Julia kernel on Windows (not mac) uses messages for interrupting (I believe Rust is the same on Mac & Windows)
@DonJayamanne DonJayamanne added the bug Issue identified by VS Code Team member as probable bug label Nov 16, 2020
@DonJayamanne DonJayamanne mentioned this issue Nov 17, 2020
Merged
@DonJayamanne DonJayamanne changed the title Kernel interrupt not working when interrupt mode is message Kernel interrupt not working when interrupt mode is message (Julia on windows) Jan 13, 2021
@greazer greazer added the notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel) label Aug 4, 2021
@DonJayamanne
Copy link
Contributor Author

Would require a refactor

@DonJayamanne DonJayamanne mentioned this issue Oct 12, 2021
Closed
1 task
@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Nov 29, 2021 •
edited
Loading

Fixed part of #8125
Dup of #8107

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug notebook-execution Kernels issues (start/restart/switch/execution, install ipykernel)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DonJayamanne @greazer