Add interrupt_mode & getSpec #3951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Nov 17, 2020
| @@ -34,6 +35,8 @@ export class JupyterKernelSpec implements IJupyterKernelSpec { | |||
| this.metadata = specModel.metadata; | |||
| // tslint:disable-next-line: no-any | |||
| this.env = specModel.env as any; // JSONObject, but should match | |||
| // tslint:disable-next-line: no-any | |||
| this.interrupt_mode = specModel.interrupt_mode as any; | |||
There was a problem hiding this comment.
This is part of the spec. If interrupt_mode = 'message' we should send a message to the kernel to interrupt. Rust is one such kernel.
Not fixing this, just exposing this information so we can use it when fixing other realted issues
DonJayamanne
commented
Nov 17, 2020
| resources | ||
| }; | ||
| } | ||
| traceError('Fetching kernel spec from raw kernel using JLab API'); | ||
| return this.realKernel.getSpec(); |
There was a problem hiding this comment.
This API doesn't work, realKernel.getSpec goes to Jupyter Lab API and that attempts to make a REST call to the base (dummy url).
This should not get executed hence added error logging.
DonJayamanne
commented
Nov 17, 2020
| public async getSpec(): Promise<Kernel.ISpecModel> { | ||
| if (this.kernelProcess.kernelConnectionMetadata.kind === 'startUsingKernelSpec') { | ||
| const kernelSpec = cloneDeep(this.kernelProcess.kernelConnectionMetadata.kernelSpec) as any; | ||
| const resources = 'resources' in kernelSpec ? kernelSpec.resources : {}; |
There was a problem hiding this comment.
When using raw kernels, we have the kernel spec, hence return that.
Not used today, but will be used in long running kernels, noop change.
rchiodo
approved these changes
Nov 17, 2020
DavidKutu
approved these changes
Nov 17, 2020
DonJayamanne
force-pushed
the
kernelApi
branch
from
b68e61d to
d54c8b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3927
This is something that came out of the long running kernels work.
It does'nt fix anything, but adds stuff we will need eventually.