Add "More Info" option to ipykernel installer prompt + wiki link to provide more info #10845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanMatthewHuff
commented
Jul 18, 2022
|
|
||
| // Link to our wiki page on jupyter kernels + ipykernel | ||
| // https://github.com/microsoft/vscode-jupyter/wiki/Jupyter-Kernels-and-the-Jupyter-Extension#python-extension-and-ipykernel | ||
| this.appShell.openUrl('https://aka.ms/AAhi594'); |
There was a problem hiding this comment.
Links to the ipykernel subsection here:
https://github.com/microsoft/vscode-jupyter/wiki/Jupyter-Kernels-and-the-Jupyter-Extension#python-extension-and-ipykernel
IanMatthewHuff
commented
Jul 18, 2022
| this.appShell.openUrl('https://aka.ms/AAhi594'); | ||
| } | ||
| // "More Info" isn't a full valid response here, so reprompt after showing it | ||
| } while (selection === moreInfoOption); |
There was a problem hiding this comment.
Loop here felt a bit funky, but I don't believe there is a way to keep open a modal dialog and provide the button selection. Returning back a KernelDependencyResponse of "moreInfo" didn't seem right, so just ask again until we get a valid response (cancel, install, selectKernel).
Codecov Report
@@ Coverage Diff @@
## main #10845 +/- ##
======================================
Coverage 63% 63%
======================================
Files 481 482 +1
Lines 33625 33695 +70
Branches 5487 5502 +15
======================================
+ Hits 21285 21362 +77
- Misses 10292 10293 +1
+ Partials 2048 2040 -8
|
amunger
approved these changes
Jul 18, 2022
DonJayamanne
approved these changes
Jul 18, 2022
rchiodo
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10658
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).