Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill child processes of a Kernel process when existing Kernel Proc #11133

Merged
merged 5 commits into from
Aug 17, 2022

Conversation

DonJayamanne
Copy link
Contributor

Fixes #11018

To be reviewed after merging #11132

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #11133 (8a0ddcc) into main (8c56132) will decrease coverage by 0%.
The diff coverage is 86%.

❗ Current head 8a0ddcc differs from pull request most recent head 125395b. Consider uploading reports for the commit 125395b to get more accurate results

@@          Coverage Diff           @@
##            main   #11133   +/-   ##
======================================
- Coverage     63%      63%   -1%     
======================================
  Files        482      482           
  Lines      33960    33981   +21     
  Branches    5541     5545    +4     
======================================
+ Hits       21492    21494    +2     
- Misses     10411    10429   +18     
- Partials    2057     2058    +1     
Impacted Files Coverage Δ
src/kernels/raw/types.ts 100% <ø> (ø)
src/kernels/raw/launcher/kernelProcess.node.ts 71% <69%> (-1%) ⬇️
src/interactive-window/interactiveWindow.ts 74% <100%> (ø)
...c/kernels/execution/cellExecutionMessageHandler.ts 77% <100%> (-1%) ⬇️
src/kernels/helpers.ts 60% <100%> (+<1%) ⬆️
src/kernels/jupyter/launcher/jupyterExecution.ts 63% <100%> (ø)
...jupyter/launcher/liveshare/hostJupyterExecution.ts 87% <100%> (ø)
...c/kernels/jupyter/launcher/notebookStarter.node.ts 68% <100%> (ø)
...kernels/jupyter/session/backingFileCreator.base.ts 68% <100%> (ø)
...nels/jupyter/session/jupyterRequestCreator.node.ts 57% <100%> (ø)
... and 30 more

@DonJayamanne DonJayamanne marked this pull request as ready for review August 17, 2022 00:01
@DonJayamanne DonJayamanne requested a review from a team as a code owner August 17, 2022 00:01
@DonJayamanne DonJayamanne merged commit 335754e into main Aug 17, 2022
@DonJayamanne DonJayamanne deleted the issue11018 branch August 17, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python processes still running after closing VSCode
4 participants