-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement restart #11668
Merged
Merged
Implement restart #11668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move commands out of DebuggingManager, and expose methods on that class for use by the rbl controller
roblourens
force-pushed
the
roblou/gentle-turkey
branch
from
October 14, 2022 21:31
6685086
to
25ca6ff
Compare
IanMatthewHuff
approved these changes
Oct 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Looks great.
Codecov Report
@@ Coverage Diff @@
## main #11668 +/- ##
========================================
- Coverage 59% 41% -18%
========================================
Files 483 486 +3
Lines 34509 34480 -29
Branches 5609 5592 -17
========================================
- Hits 20401 14359 -6042
- Misses 12128 18908 +6780
+ Partials 1980 1213 -767
|
Also fix the restart request handler to avoid cancelling the restart request on accident.
connor4312
approved these changes
Oct 21, 2022
sbatten
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #7670
Also includes some refactoring so that this flow reads more nicely.
I had to
Remaining: This is not hooked up for IW debugging yet