Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give preference to env variables from Python ext #11816

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

DonJayamanne
Copy link
Contributor

Better logging for #11813

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #11816 (cb43589) into main (0eda1bc) will decrease coverage by 0%.
The diff coverage is 80%.

❗ Current head cb43589 differs from pull request most recent head a0094ab. Consider uploading reports for the commit a0094ab to get more accurate results

@@          Coverage Diff           @@
##            main   #11816   +/-   ##
======================================
- Coverage     62%      62%   -1%     
======================================
  Files        486      486           
  Lines      34588    34587    -1     
  Branches    5615     5614    -1     
======================================
- Hits       21755    21738   -17     
+ Misses     10783    10781    -2     
- Partials    2050     2068   +18     
Impacted Files Coverage Δ
...ommon/process/environmentActivationService.node.ts 67% <80%> (+<1%) ⬆️
src/kernels/execution/notebookUpdater.ts 88% <0%> (-8%) ⬇️
...otebooks/controllers/controllerPreferredService.ts 79% <0%> (-5%) ⬇️
src/platform/common/cancellation.ts 68% <0%> (-4%) ⬇️
...form/common/process/pythonExecutionFactory.node.ts 76% <0%> (-3%) ⬇️
src/kernels/raw/finder/localKernelFinder.node.ts 86% <0%> (-2%) ⬇️
src/kernels/jupyter/jupyterKernelService.node.ts 72% <0%> (-2%) ⬇️
src/notebooks/debugger/debuggingManagerBase.ts 66% <0%> (-2%) ⬇️
src/notebooks/controllers/kernelRanking/helpers.ts 60% <0%> (-2%) ⬇️
src/platform/common/utils/async.ts 49% <0%> (-2%) ⬇️
... and 10 more

@DonJayamanne DonJayamanne enabled auto-merge (squash) October 26, 2022 18:47
@DonJayamanne DonJayamanne merged commit 9ae2d56 into main Oct 26, 2022
@DonJayamanne DonJayamanne deleted the issue11813 branch October 26, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants