Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No active PythonEnv controller for new kernel pick #11933

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

DonJayamanne
Copy link
Contributor

Partially addresses #11932
Requires more work in subsequent PRs

@codecov-commenter
Copy link

Codecov Report

Merging #11933 (2bd8207) into main (3c58033) will increase coverage by 0%.
The diff coverage is 83%.

@@          Coverage Diff           @@
##            main   #11933   +/-   ##
======================================
  Coverage     62%      62%           
======================================
  Files        490      490           
  Lines      34602    34605    +3     
  Branches    5616     5617    +1     
======================================
+ Hits       21691    21709   +18     
+ Misses     10831    10808   -23     
- Partials    2080     2088    +8     
Impacted Files Coverage Δ
src/notebooks/controllers/controllerLoader.ts 90% <83%> (-2%) ⬇️
src/platform/common/configuration/service.base.ts 76% <0%> (-3%) ⬇️
...c/platform/common/process/pythonDaemonPool.node.ts 77% <0%> (-2%) ⬇️
src/platform/common/process/condaService.node.ts 67% <0%> (-2%) ⬇️
src/notebooks/controllers/kernelRanking/helpers.ts 55% <0%> (-2%) ⬇️
...els/jupyter/finder/remoteKernelFinderController.ts 61% <0%> (-1%) ⬇️
src/kernels/kernelDependencyService.node.ts 83% <0%> (-1%) ⬇️
src/kernels/jupyter/launcher/serverUriStorage.ts 61% <0%> (-1%) ⬇️
...c/kernels/execution/cellExecutionMessageHandler.ts 77% <0%> (-1%) ⬇️
src/notebooks/debugger/debuggerVariables.ts 67% <0%> (-1%) ⬇️
... and 8 more

Copy link
Member

@rebornix rebornix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rebornix rebornix merged commit 546aa29 into main Nov 7, 2022
@rebornix rebornix deleted the issue11932 branch November 7, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants