Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt new document symbol api #15253

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Adopt new document symbol api #15253

merged 3 commits into from
Mar 17, 2024

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Feb 27, 2024 •
edited
Loading

New document symbol api for fetching symbols which include module alias

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rebornix rebornix marked this pull request as ready for review March 17, 2024 21:08
@vscodenpa vscodenpa added this to the March 2024 milestone Mar 17, 2024
@rebornix rebornix enabled auto-merge (squash) March 17, 2024 21:10
@rebornix rebornix merged commit 6c1cac0 into main Mar 17, 2024
28 checks passed
@rebornix rebornix deleted the rebornix/immense-tarsier branch March 17, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

@rebornix rebornix

Labels
None yet
Projects
None yet
Milestone
March 2024
Development

Successfully merging this pull request may close these issues.
3 participants
@rebornix @DonJayamanne @vscodenpa