Use ipynb extension to serialize and drop ICell #15383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
force-pushed
the
issue15380
branch
from
210207c to
5db82ec
Compare
DonJayamanne
force-pushed
the
issue15380
branch
from
b376ca3 to
1778aeb
Compare
DonJayamanne
commented
Mar 18, 2024
| @@ -102,8 +102,8 @@ export interface IInteractiveWindow extends IInteractiveBase { | |||
| expandAllCells(): Promise<void>; | |||
| collapseAllCells(): Promise<void>; | |||
| scrollToCell(id: string): void; | |||
| exportAs(cells?: ICell[]): void; | |||
| export(cells?: ICell[]): void; | |||
There was a problem hiding this comment.
Never passed anywhere.
DonJayamanne
commented
Mar 18, 2024
| @@ -34,7 +33,6 @@ export type LoadIPyWidgetClassLoadAction = { | |||
| }; | |||
|
|
|||
| export enum InteractiveWindowMessages { | |||
| FinishCell = 'finish_cell', | |||
DonJayamanne
commented
Mar 18, 2024
| @@ -293,34 +288,6 @@ function updateExecutionCount(arg: VariableReducerArg<{ executionCount: number } | |||
| }); | |||
| } | |||
|
|
|||
| function handleFinishCell(arg: VariableReducerArg<IFinishCell>): IVariableState { | |||
amunger
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15380