Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary when condition so command can be menu defualt #15546

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Apr 15, 2024

Fixes microsoft/vscode#210286

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@vscodenpa vscodenpa added this to the April 2024 milestone Apr 15, 2024
@amunger amunger merged commit 5a80a72 into main Apr 15, 2024
28 checks passed
@amunger amunger deleted the aamunger/runInIWCanBeDefault branch April 15, 2024 17:03
@amunger amunger restored the aamunger/runInIWCanBeDefault branch April 15, 2024 18:30
@amunger amunger deleted the aamunger/runInIWCanBeDefault branch January 30, 2025 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editor/title/run rememberDefault doesn't remember that jupyter.runFileInteractive was last selected
3 participants