Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store interpreter information in notebook metadata and stop listing default kernespecs #5732

Merged
merged 7 commits into from
May 4, 2021

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented May 3, 2021

For #5612
For #5445

@DonJayamanne DonJayamanne marked this pull request as ready for review May 3, 2021 18:57
@DonJayamanne DonJayamanne requested a review from a team as a code owner May 3, 2021 18:57
@codecov-commenter
Copy link

codecov-commenter commented May 3, 2021

Codecov Report

Merging #5732 (905538b) into main (c7d5fde) will increase coverage by 3%.
The diff coverage is 79%.

@@          Coverage Diff           @@
##            main   #5732    +/-   ##
======================================
+ Coverage     69%     72%    +3%     
======================================
  Files        403     403            
  Lines      26851   26865    +14     
  Branches    3910    3914     +4     
======================================
+ Hits       18595   19549   +954     
+ Misses      6637    5671   -966     
- Partials    1619    1645    +26     
Impacted Files Coverage Δ
...t/datascience/kernel-launcher/localKernelFinder.ts 82% <73%> (+<1%) ⬆️
src/client/datascience/jupyter/kernels/helpers.ts 74% <100%> (+2%) ⬆️
...rc/client/datascience/notebookStorage/baseModel.ts 80% <100%> (+9%) ⬆️
src/client/datascience/notebook/helpers/helpers.ts 72% <0%> (-2%) ⬇️
...t/datascience/notebook/vscodeNotebookController.ts 76% <0%> (-1%) ⬇️
.../datascience/notebook/notebookControllerManager.ts 84% <0%> (-1%) ⬇️
...ient/datascience/editor-integration/codewatcher.ts 69% <0%> (-1%) ⬇️
...atascience/jupyter/kernels/jupyterKernelService.ts 80% <0%> (+<1%) ⬆️
src/client/common/configSettings.ts 90% <0%> (+<1%) ⬆️
...atascience/kernel-launcher/kernelLauncherDaemon.ts 94% <0%> (+<1%) ⬆️
... and 66 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants