-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List global python kernelspecs #6676
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6676 +/- ##
======================================
- Coverage 69% 69% -1%
======================================
Files 412 412
Lines 28473 28499 +26
Branches 4241 4249 +8
======================================
- Hits 19825 19705 -120
- Misses 6991 7124 +133
- Partials 1657 1670 +13
|
@@ -42,6 +43,10 @@ export abstract class LocalKernelSpecFinderBase { | |||
protected readonly extensionChecker: IPythonExtensionChecker | |||
) {} | |||
|
|||
@testOnlyMethod() | |||
public clearCache() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add tests later, after i finish ipykernel6 stuff (seprate PR)
assert.include(items, 'to_bytes'); | ||
assert.ok( | ||
items.find((item) => | ||
typeof item === 'string' ? item.includes('bit_length') : item.label.includes('bit_length') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes tests with failing code completion (this is a bug in jupyter, changes are breaking us, the return value is different)
We already have an issue to fix the underlying bug (this way this test passes)
For #6622