Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List global python kernelspecs #6676

Merged
merged 3 commits into from
Jul 15, 2021
Merged

List global python kernelspecs #6676

merged 3 commits into from
Jul 15, 2021

Conversation

DonJayamanne
Copy link
Contributor

For #6622

@DonJayamanne DonJayamanne requested a review from a team as a code owner July 15, 2021 17:04
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2021

Codecov Report

Merging #6676 (1776c0f) into main (ee7729a) will decrease coverage by 0%.
The diff coverage is 44%.

❗ Current head 1776c0f differs from pull request most recent head 2ef68f1. Consider uploading reports for the commit 2ef68f1 to get more accurate results

@@          Coverage Diff           @@
##            main   #6676    +/-   ##
======================================
- Coverage     69%     69%    -1%     
======================================
  Files        412     412            
  Lines      28473   28499    +26     
  Branches    4241    4249     +8     
======================================
- Hits       19825   19705   -120     
- Misses      6991    7124   +133     
- Partials    1657    1670    +13     
Impacted Files Coverage Δ
.../localPythonAndRelatedNonPythonKernelSpecFinder.ts 80% <41%> (-7%) ⬇️
...ience/kernel-launcher/localKernelSpecFinderBase.ts 81% <66%> (-1%) ⬇️
...ience/variablesView/variableViewMessageListener.ts 22% <0%> (-78%) ⬇️
...ent/common/application/webviewViews/webviewView.ts 14% <0%> (-72%) ⬇️
...c/client/datascience/variablesView/variableView.ts 18% <0%> (-62%) ⬇️
src/client/datascience/webviews/webviewViewHost.ts 19% <0%> (-53%) ⬇️
...on/application/webviewViews/webviewViewProvider.ts 80% <0%> (-20%) ⬇️
.../datascience/variablesView/variableViewProvider.ts 65% <0%> (-16%) ⬇️
...lient/datascience/variablesView/notebookWatcher.ts 80% <0%> (-14%) ⬇️
src/client/datascience/webviews/webviewHost.ts 80% <0%> (-7%) ⬇️
... and 11 more

@@ -42,6 +43,10 @@ export abstract class LocalKernelSpecFinderBase {
protected readonly extensionChecker: IPythonExtensionChecker
) {}

@testOnlyMethod()
public clearCache() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add tests later, after i finish ipykernel6 stuff (seprate PR)

assert.include(items, 'to_bytes');
assert.ok(
items.find((item) =>
typeof item === 'string' ? item.includes('bit_length') : item.label.includes('bit_length')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes tests with failing code completion (this is a bug in jupyter, changes are breaking us, the return value is different)
We already have an issue to fix the underlying bug (this way this test passes)

@DonJayamanne DonJayamanne merged commit 0d2170b into main Jul 15, 2021
@DonJayamanne DonJayamanne deleted the issue6622 branch July 15, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants