Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python exec path in kernelspec need not match exactly with interpreter path #6959

Merged
merged 2 commits into from
Aug 3, 2021

Conversation

DonJayamanne
Copy link
Contributor

For #6622

@DonJayamanne DonJayamanne requested a review from a team as a code owner August 3, 2021 18:01
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2021

Codecov Report

Merging #6959 (6536fd0) into main (db645c3) will decrease coverage by 0%.
The diff coverage is 59%.

❗ Current head 6536fd0 differs from pull request most recent head 96fa1cc. Consider uploading reports for the commit 96fa1cc to get more accurate results

@@          Coverage Diff           @@
##            main   #6959    +/-   ##
======================================
- Coverage     65%     64%    -1%     
======================================
  Files        410     410            
  Lines      28528   28532     +4     
  Branches    4263    4265     +2     
======================================
- Hits       18621   18430   -191     
- Misses      8278    8491   +213     
+ Partials    1629    1611    -18     
Impacted Files Coverage Δ
.../localPythonAndRelatedNonPythonKernelSpecFinder.ts 79% <59%> (-1%) ⬇️
...ience/variablesView/variableViewMessageListener.ts 22% <0%> (-78%) ⬇️
...ent/common/application/webviewViews/webviewView.ts 14% <0%> (-72%) ⬇️
...c/client/datascience/variablesView/variableView.ts 18% <0%> (-62%) ⬇️
src/client/common/application/webviews/webview.ts 13% <0%> (-54%) ⬇️
src/client/datascience/webviews/webviewViewHost.ts 19% <0%> (-53%) ⬇️
...on/application/webviewViews/webviewViewProvider.ts 80% <0%> (-20%) ⬇️
.../datascience/variablesView/variableViewProvider.ts 65% <0%> (-16%) ⬇️
...lient/datascience/variablesView/notebookWatcher.ts 80% <0%> (-13%) ⬇️
src/client/datascience/webviews/webviewHost.ts 78% <0%> (-8%) ⬇️
... and 18 more

@DonJayamanne DonJayamanne merged commit 5ba500e into main Aug 3, 2021
@DonJayamanne DonJayamanne deleted the issue6622GetInterpreterInfo branch August 3, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants