Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove canDebug context key #7077

Merged
merged 6 commits into from
Aug 12, 2021
Merged

remove canDebug context key #7077

merged 6 commits into from
Aug 12, 2021

Conversation

DavidKutu
Copy link

@DavidKutu DavidKutu commented Aug 11, 2021

For #7056

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #7077 (149c8c6) into main (e0dc6dd) will decrease coverage by 1%.
The diff coverage is 20%.

❗ Current head 149c8c6 differs from pull request most recent head d334c6b. Consider uploading reports for the commit d334c6b to get more accurate results

@@          Coverage Diff           @@
##            main   #7077    +/-   ##
======================================
- Coverage     65%     63%    -2%     
======================================
  Files        362     362            
  Lines      22897   22885    -12     
  Branches    3426    3425     -1     
======================================
- Hits       14910   14494   -416     
- Misses      6683    7170   +487     
+ Partials    1304    1221    -83     
Impacted Files Coverage Δ
src/client/datascience/constants.ts 99% <ø> (-1%) ⬇️
...science/jupyter/kernels/kernelDependencyService.ts 88% <ø> (-1%) ⬇️
src/client/datascience/types.ts 100% <ø> (ø)
src/client/debugger/jupyter/debuggingManager.ts 25% <15%> (-4%) ⬇️
src/client/common/utils/localize.ts 95% <100%> (+<1%) ⬆️
...client/datascience/commands/activeEditorContext.ts 87% <100%> (-3%) ⬇️
...ience/variablesView/variableViewMessageListener.ts 22% <0%> (-78%) ⬇️
...ent/common/application/webviewViews/webviewView.ts 14% <0%> (-72%) ⬇️
...c/client/datascience/variablesView/variableView.ts 17% <0%> (-61%) ⬇️
src/client/datascience/webviews/webviewViewHost.ts 21% <0%> (-58%) ⬇️
... and 24 more

@DavidKutu DavidKutu marked this pull request as ready for review August 11, 2021 23:08
@DavidKutu DavidKutu requested a review from a team as a code owner August 11, 2021 23:08
@DavidKutu DavidKutu requested a review from roblourens August 11, 2021 23:31
@@ -480,6 +480,7 @@
"DataScience.interactiveWindowModeBannerSwitchAlways": "Always",
"DataScience.interactiveWindowModeBannerSwitchNo": "No",
"DataScience.ipykernelNotInstalled": "IPyKernel not installed into interpreter {0}",
"DataScience.needIpykernel6": "Ipykernel 6 is needed for debugging, click Install to continue. Or you can run 'pip install ipykernel==6.0.3/conda install ipykernel=6'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better command line to recommend? I feel like pip install --upgrade ipykernel would work too? Or maybe that doesn't always work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But at least the 6.0.3 version seems rather specific

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this a lot. Unfortunately, --upgrade didn't upgrade mine from 5.5.5 to 6

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have an issue on the python extension to fix the installer. If that's fixed, I'll remove the commands from the message.
microsoft/vscode-python#16937

@roblourens
Copy link
Member

How does this know not to show the RBL button on non-Python notebooks?

@DavidKutu
Copy link
Author

@roblourens I'll add a check on package.json

@DavidKutu DavidKutu merged commit 7d4c89c into main Aug 12, 2021
@DavidKutu DavidKutu deleted the david/catchIpykernelDebugError branch August 12, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants