-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove canDebug context key #7077
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7077 +/- ##
======================================
- Coverage 65% 63% -2%
======================================
Files 362 362
Lines 22897 22885 -12
Branches 3426 3425 -1
======================================
- Hits 14910 14494 -416
- Misses 6683 7170 +487
+ Partials 1304 1221 -83
|
@@ -480,6 +480,7 @@ | |||
"DataScience.interactiveWindowModeBannerSwitchAlways": "Always", | |||
"DataScience.interactiveWindowModeBannerSwitchNo": "No", | |||
"DataScience.ipykernelNotInstalled": "IPyKernel not installed into interpreter {0}", | |||
"DataScience.needIpykernel6": "Ipykernel 6 is needed for debugging, click Install to continue. Or you can run 'pip install ipykernel==6.0.3/conda install ipykernel=6'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a better command line to recommend? I feel like pip install --upgrade ipykernel would work too? Or maybe that doesn't always work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But at least the 6.0.3 version seems rather specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this a lot. Unfortunately, --upgrade didn't upgrade mine from 5.5.5 to 6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have an issue on the python extension to fix the installer. If that's fixed, I'll remove the commands from the message.
microsoft/vscode-python#16937
How does this know not to show the RBL button on non-Python notebooks? |
@roblourens I'll add a check on package.json |
For #7056
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).