avoid unnecessary scopes and variables calls #7313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7313 +/- ##
======================================
Coverage 62% 63%
======================================
Files 360 360
Lines 22539 22551 +12
Branches 3404 3412 +8
======================================
+ Hits 14080 14209 +129
+ Misses 7284 7155 -129
- Partials 1175 1187 +12
|
joyceerhl
reviewed
Aug 26, 2021
| @@ -377,7 +377,11 @@ export class KernelDebugAdapter implements DebugAdapter, IKernelDebugAdapter, ID | |||
| // Here we catch the stackTrace response and we use its id to send a scope message | |||
| if ((message as DebugProtocol.StackTraceResponse).command === 'stackTrace') { | |||
| (message as DebugProtocol.StackTraceResponse).body.stackFrames.forEach((sf) => { | |||
| this.scopes(sf.id); | |||
| // Only call scopes (and variables) if we are stopped on the cell we are executing | |||
| const cell = this.notebookDocument.cellAt(this.configuration.__cellIndex!); | |||
There was a problem hiding this comment.
Is this.configuration.__cellIndex always guaranteed to be defined here?
There was a problem hiding this comment.
not in all cases, I'll use the notebook URI
joyceerhl
approved these changes
Aug 26, 2021
roblourens
reviewed
Aug 27, 2021
| @@ -377,7 +377,11 @@ export class KernelDebugAdapter implements DebugAdapter, IKernelDebugAdapter, ID | |||
| // Here we catch the stackTrace response and we use its id to send a scope message | |||
| if ((message as DebugProtocol.StackTraceResponse).command === 'stackTrace') { | |||
| (message as DebugProtocol.StackTraceResponse).body.stackFrames.forEach((sf) => { | |||
There was a problem hiding this comment.
It could even be optimized more - this will send the request for the cell's frame even if it is not the first frame in the stack, like when you have stepped into another cell. But it won't send it for other frames, which is good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7246
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).