Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORT: put BP on first code line (#7324) #7341

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

DavidKutu
Copy link

@DavidKutu DavidKutu commented Aug 30, 2021

  • put BP on first code line

  • better way

  • don't set a breakpoint if its all comments or empty
    lines

  • PR comments

For #7339

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

* put BP on first code line

* better way

* don't set a breakpoint if its all comments or empty
lines

* PR comments
@DavidKutu DavidKutu requested a review from a team as a code owner August 30, 2021 18:03
@DavidKutu DavidKutu changed the title put BP on first code line (#7324) PORT: put BP on first code line (#7324) Aug 30, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-2021.08.203@7fee5d2). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             release-2021.08.203   #7341   +/-   ##
=====================================================
  Coverage                       ?     63%           
=====================================================
  Files                          ?     360           
  Lines                          ?   22562           
  Branches                       ?    3415           
=====================================================
  Hits                           ?   14230           
  Misses                         ?    7148           
  Partials                       ?    1184           

@DavidKutu DavidKutu merged commit acfd4b8 into release-2021.08.203 Aug 30, 2021
@DavidKutu DavidKutu deleted the david/portPutBPOnFirstCodeLine branch August 30, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants