Suppress save before starting notebook debug session. #7393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can debug untitled notebooks cleanly, and it's not needed for other unsaved notebooks anyway. Fix #6898
|
I just pushed this option to vscode so it isn't in an Insiders build yet |
Codecov Report
@@ Coverage Diff @@
## main #7393 +/- ##
=====================================
Coverage 64% 64%
=====================================
Files 361 361
Lines 22563 22563
Branches 3416 3415 -1
=====================================
+ Hits 14499 14502 +3
+ Misses 6866 6858 -8
- Partials 1198 1203 +5
|
DavidKutu
approved these changes
Sep 2, 2021
DonJayamanne
reviewed
Sep 2, 2021
| const opts = mode === KernelDebugMode.RunByLine ? { debugUI: { simple: true } } : undefined; | ||
| const opts: DebugSessionOptions | undefined = | ||
| mode === KernelDebugMode.RunByLine | ||
| ? { debugUI: { simple: true }, suppressSaveBeforeStart: true } |
There was a problem hiding this comment.
@roblourens
Is this avaialble in VS Code 1.60 stable?
There was a problem hiding this comment.
But it will be ignored and not cause an issue, if that's what you're wondering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can debug untitled notebooks cleanly, and it's not needed for other unsaved notebooks anyway.
Fix #6898
Has a [news entry](https://github.com/Microsoft/vscode-jupyter/tree/main/news) file (remember to thank yourself!).Has sufficient logging.Has telemetry for enhancements.Unit tests & system/integration tests are added/updated.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).