Display python error message when kernel dies #7646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Sep 23, 2021
| // Show the error message | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| void this.applicationShell.showErrorMessage( | ||
| exc instanceof Error ? exc.message : (exc as any).toString() |
There was a problem hiding this comment.
Cleaner than displaying a to string version of the error.
DonJayamanne
commented
Sep 23, 2021
| @@ -245,9 +245,7 @@ export class KernelExecution implements IDisposable { | |||
| @captureTelemetry(Telemetry.RestartJupyterTime) | |||
| private async restartExecution(notebook: INotebook): Promise<void> { | |||
| // Just use the internal session. Pending cells should have been canceled by the caller | |||
| await notebook.session.restart(this.interruptTimeout).catch((exc) => { | |||
| traceWarning(`Error during restart: ${exc}`); | |||
| }); | |||
There was a problem hiding this comment.
This was a bug, we were swalling errors when restarting kernels, its as though everything went fine, when infact the kernel actually died.
DonJayamanne
commented
Sep 23, 2021
| const message = | ||
| 'exitCode' in options | ||
| ? `Kernel died with exit code ${options.exitCode}. ${options.reason}` | ||
| ? `Kernel died (code: ${options.exitCode}). ${reason}${options.reason}` |
There was a problem hiding this comment.
Updated to incldue error message in the first line (in python stack traces the error message is at the end, this way we extract the last line & put it on top of the error message)
There was a problem hiding this comment.
What does it look like in the UI?
There was a problem hiding this comment.
Sorry, meant to upload that, took the screenshots earlier.
here they are
DonJayamanne
requested review from
DavidKutu,
IanMatthewHuff,
joyceerhl and
rchiodo
and removed request for
a team
rchiodo
approved these changes
Sep 23, 2021
Codecov Report
@@ Coverage Diff @@
## main #7646 +/- ##
=====================================
Coverage 68% 68%
=====================================
Files 363 363
Lines 22546 22535 -11
Branches 3430 3431 +1
=====================================
- Hits 15490 15489 -1
+ Misses 5724 5715 -9
+ Partials 1332 1331 -1
|
IanMatthewHuff
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7318