Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show modal error when remote jupyter connect fails #8476

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Conversation

DonJayamanne
Copy link
Contributor

For #8474

Should unblock users in remote, even those who forget to swtich back from remote to local

@DonJayamanne DonJayamanne requested a review from a team as a code owner December 7, 2021 23:16
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021

Codecov Report

Merging #8476 (01edd6b) into main (74ca817) will increase coverage by 0%.
The diff coverage is 54%.

❗ Current head 01edd6b differs from pull request most recent head d4728b2. Consider uploading reports for the commit d4728b2 to get more accurate results

@@          Coverage Diff          @@
##            main   #8476   +/-   ##
=====================================
  Coverage     71%     71%           
=====================================
  Files        377     377           
  Lines      23913   23934   +21     
  Branches    3679    3682    +3     
=====================================
+ Hits       17200   17216   +16     
+ Misses      5253    5215   -38     
- Partials    1460    1503   +43     
Impacted Files Coverage Δ
src/client/datascience/jupyter/serverSelector.ts 73% <ø> (ø)
src/client/telemetry/index.ts 63% <ø> (ø)
.../datascience/notebook/notebookControllerManager.ts 72% <42%> (-2%) ⬇️
src/client/common/utils/localize.ts 95% <100%> (+<1%) ⬆️
...ience/interactive-common/notebookServerProvider.ts 74% <100%> (-5%) ⬇️
...ence/editor-integration/cellHashProviderFactory.ts 97% <0%> (-3%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 73% <0%> (-1%) ⬇️
src/client/common/configuration/service.ts 82% <0%> (ø)
src/client/datascience/jupyter/jupyterUtils.ts 65% <0%> (ø)
... and 12 more

@DonJayamanne DonJayamanne merged commit 57f958f into main Dec 8, 2021
@DonJayamanne DonJayamanne deleted the issue8474 branch December 8, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants