Avoid waiting for completions request #9043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Feb 16, 2022
| @@ -662,17 +662,8 @@ export class Kernel implements IKernel { | |||
| // Restart sessions and retries might make this hard to do correctly otherwise. | |||
| notebook.session.registerCommTarget(Identifiers.DefaultCommTarget, noop); | |||
|
|
|||
| // Request completions to warm up the completion engine (first call always takes a lot longer) | |||
| const completionPromise = this.requestEmptyCompletions(); | |||
There was a problem hiding this comment.
THe problem is we can see errors in the console, basically kernel is logging errors, however its an unhandled exception and the kernel is not able to send back a failure response.
Hence we end up waiting indefinitely for the promise to resolve as we don't ever get a response.
Fortunately in other places when we make this request, we have a timeout (to not wait and block VS Code for completions).
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9014