Fix the vscode-languageserver-* imports #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package was importing code from `vscode-languageserver`. However, it doesn’t specify `vscode-languageserver` as a dependency. All imports used, were just re-exports from the `vscode-languageserver-protocol` package. It was also importing code from the `vscode-languageserver-types` package. This changes all imports from `vscode-languageserver` and `vscode-languageserver-types` to `vscode-languageserver-protocol` imports, and adds this mising dependency. Also the `vscode-languageserver-textdocument` dependency was moved into `devDependencies`, because it’s only used in a test and in the example.
remcohaszing
force-pushed
the
fix-languageserver-imports
branch
from
95b51f5 to
bbd585e
Compare
mjbvz
approved these changes
Mar 11, 2024
amunger
approved these changes
Mar 11, 2024
|
Thanks @remcohaszing! Will publish an alpha release with this shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package was importing code from
vscode-languageserver. However, it doesn’t specifyvscode-languageserveras a dependency. All imports used, were just re-exports from thevscode-languageserver-protocolpackage. It was also importing code from thevscode-languageserver-typespackage.This changes all imports from
vscode-languageserverandvscode-languageserver-typestovscode-languageserver-protocolimports, and adds this mising dependency.Also the
vscode-languageserver-textdocumentdependency was moved intodevDependencies, because it’s only used in a test and in the example.