DRAFT PR - Edit Data #18533
Draft
DRAFT PR - Edit Data #18533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis-sanchez
requested review from
kburtram,
aasimkhan30,
cssuh,
caohai,
laurennat and
Benjin
as code owners
PR Changes
|
Benjin
reviewed
Jan 7, 2025
| @@ -484,6 +484,11 @@ | |||
| "when": "view == objectExplorer && viewItem =~ /\\btype=(AggregateFunction|PartitionFunction|ScalarValuedFunction|StoredProcedure|TableValuedFunction|View)\\b/", | |||
| "group": "MS_SQL@4" | |||
| }, | |||
| { | |||
| "command": "mssql.editData", | |||
| "when": "view == objectExplorer && viewItem =~ /\\btype=(Table)\\b/", | |||
There was a problem hiding this comment.
if you gate the feature behind the "enable preview features" flag as well, then it'll be easier to check in changes as they're ready. One thing we want to avoid is to wait until the feature is almost done, then have a huge PR because that's more difficult to effectively review.
| super( | ||
| context, | ||
| "editData", | ||
| data ?? { |
There was a problem hiding this comment.
This is the initial state for EditDataWebViewState, right? Probably good to have this situated with the definition for EditDataWebViewState.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.