Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sort button to column header #18561

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Add a sort button to column header #18561

wants to merge 5 commits into from

Conversation

cssuh
Copy link
Member

@cssuh cssuh commented Jan 17, 2025

Adding a sort button to each column header and removing it from the filter menu:
Screenshot 2025-01-17 at 7 38 59 AM

 Behavior:
sortButton

(also replaced old sort indicator assets)

Copy link

github-actions bot commented Jan 17, 2025

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 50.40% 50.48% $${\color{lightgreen} .08\% }$$
VSIX Size 12161 KB 12130 KB $${\color{lightgreen} -31 KB \space (0\%) }$$
Webview Bundle Size 3180 KB 3124 KB $${\color{lightgreen} -56 KB \space (-1\%) }$$

@cssuh cssuh marked this pull request as draft January 17, 2025 22:48
@cssuh
Copy link
Member Author

cssuh commented Jan 21, 2025

Marking as draft because I still need to sort out some multi-column sort scenarios, and will continue work after ask mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant