Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visuals on the PR overview page #2648

Closed
kieferrm opened this issue Apr 9, 2021 · 1 comment · Fixed by #2796
Closed

Visuals on the PR overview page #2648

kieferrm opened this issue Apr 9, 2021 · 1 comment · Fixed by #2796
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@kieferrm
Copy link
Member

kieferrm commented Apr 9, 2021

Pls see

image

A) propose to increase the vertical space between the button row and the title/date of the PR
B) While "Reviewers" is a title "None yet" is a value. Proposal to visually show that difference by color, font, or borders
C) Missing alignment
D) Propose to increate the vertical space between the check list and the button; increase the horizontal space between "using method" and the drop down

@kieferrm kieferrm assigned alexr00 and unassigned RMacfarlane Jun 7, 2021
@alexr00 alexr00 added this to the June 2021 milestone Jun 7, 2021
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jun 7, 2021
@egamma egamma mentioned this issue Jun 14, 2021
7 tasks
alexr00 added a commit that referenced this issue Jun 23, 2021
alexr00 added a commit that referenced this issue Jun 23, 2021
@alexr00
Copy link
Member

alexr00 commented Jun 23, 2021

A) The buttons are currently intended to be aligned with the title, however they are currently a little too low. I've moved them to line up better with the title. If instead you were proposing that we move the buttons up above the title (still right aligned), then I will try that out.
B) Has already been addressed with bold and italics.
C) Looks like this one has already been addressed too.
D) Increased the vertical space by 4px. Fixed the missing space before the drop down.

image

@mjbvz mjbvz added the verified Verification succeeded label Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants