Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edits to comments on PRs not being applied #2869

Closed
stuartleeks opened this issue Jul 28, 2021 · 0 comments · Fixed by #2875
Closed

Edits to comments on PRs not being applied #2869

stuartleeks opened this issue Jul 28, 2021 · 0 comments · Fixed by #2875
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
August 2021

Comments

@stuartleeks
Copy link

Found while testing #2722 (repo opened via Remote-Repositories)

  • Extension version: v2021.7.39424 (nightly)
  • VSCode Version: 1.59.0-insider (user setup)
  • OS: Windows_NT x64 10.0.19043

Steps to Reproduce:

  1. View a PR and add a comment
    image

  2. Click the edit button and edit the comment
    image

  3. Click save
    image

Note that the comment has reverted to the original value. Checking via github.com the PR still shows the original comment

image
@alexr00 alexr00 self-assigned this Jul 30, 2021
@alexr00 alexr00 added this to the August 2021 milestone Jul 30, 2021
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jul 30, 2021
alexr00 added a commit that referenced this issue Aug 2, 2021
@alexr00
Edits to comments on PRs not being applied
e4960bc 
Fixes #2869
@alexr00 alexr00 mentioned this issue Aug 2, 2021
Merged
alexr00 added a commit that referenced this issue Aug 9, 2021
@alexr00
Edits to comments on PRs not being applied (#2875)
f0a91bb 
Fixes #2869
@rzhao271 rzhao271 added the verified Verification succeeded label Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

Successfully merging a pull request may close this issue.

Edits to comments on PRs not being applied microsoft/vscode-pull-request-github
3 participants
@stuartleeks @rzhao271 @alexr00