Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow checked out PRs to show diffs only against PR head #4720

Closed
alexr00 opened this issue Apr 13, 2023 · 1 comment · Fixed by #4845
Closed

Allow checked out PRs to show diffs only against PR head #4720

alexr00 opened this issue Apr 13, 2023 · 1 comment · Fixed by #4845
Assignees
@alexr00
Labels
feature-request Request for new features or functionality on-testplan
Milestone
May 2023

Comments

@alexr00
Copy link
Member

alexr00 commented Apr 13, 2023 •
edited
Loading

Currently, a checked out PR shows diffs between the base branch and your git working tree (basically your files on disk). We should offer a way to change this diff to be between the base branch and the remote head branch of the PR.

Some implications:

  • This would mean that right side of the diff, which is currently editable, would be read only (at least when this is different from the file on disk).
  • This might cause problems with the quick diff (investigation needed).

@hediet FYI and thanks for continuously providing feedback!
@alexr00 alexr00 added the feature-request Request for new features or functionality label Apr 13, 2023
@alexr00 alexr00 added this to the May 2023 milestone Apr 13, 2023
@alexr00 alexr00 self-assigned this Apr 13, 2023
@hediet
Copy link
Member

hediet commented Apr 24, 2023 •
edited
Loading

Currently, a checked out PR shows diffs between the base branch and your git working tree (basically your files on disk).

Afaik it currently only shows files changed in the PR! If you change an unrelated file in the workspace, afaik, it does not show up.

@kieferrm kieferrm mentioned this issue May 9, 2023
Closed
76 tasks
@alexr00 alexr00 changed the title Allow checked-ed out PRs to show diffs only against PR head Allow checked out PRs to show diffs only against PR head May 17, 2023
alexr00 added a commit that referenced this issue May 24, 2023
@alexr00
Allow checked out PRs to show diffs only against PR head
a246afc 
Fixes #4720
@alexr00 alexr00 mentioned this issue May 24, 2023
Merged
alexr00 added a commit that referenced this issue May 24, 2023
@alexr00
Allow checked out PRs to show diffs only against PR head (#4845)
e187b59 
Fixes #4720
@alexr00 alexr00 mentioned this issue May 26, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality on-testplan
Projects
None yet
Milestone
May 2023
Development

Successfully merging a pull request may close this issue.

Allow checked out PRs to show diffs only against PR head microsoft/vscode-pull-request-github
2 participants
@hediet @alexr00